Skip to content

435 get khiops version among extra info#439

Merged
tramora merged 1 commit intodev-v10from
435-get-khiops-version-among-extra-info
Aug 4, 2025
Merged

435 get khiops version among extra info#439
tramora merged 1 commit intodev-v10from
435-get-khiops-version-among-extra-info

Conversation

@tramora
Copy link
Copy Markdown
Collaborator

@tramora tramora commented Jul 26, 2025 •
edited
Loading

Fixes #435

When putting debugging extra info, khiops core does not use a OS specific line separator but always a Unix separator.
Because of this khiops-python couldn't get correctly the version on Windows.

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@tramora tramora force-pushed the 435-get-khiops-version-among-extra-info branch from 027c0e5 to 9e7eb21 Compare July 26, 2025 14:42
@popescu-v popescu-v mentioned this pull request Jul 28, 2025
Closed
popescu-v
popescu-v reviewed Jul 28, 2025
View reviewed changes
popescu-v
popescu-v reviewed Jul 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment.

@tramora tramora force-pushed the 435-get-khiops-version-among-extra-info branch from 9e7eb21 to f100217 Compare July 30, 2025 13:21
@tramora tramora requested a review from popescu-v July 30, 2025 13:22
popescu-v
popescu-v approved these changes Jul 31, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to be backported to dev after merge.

@popescu-v popescu-v linked an issue Jul 31, 2025 that may be closed by this pull request
Invalid version checks #436
Closed
@popescu-v popescu-v removed a link to an issue Jul 31, 2025
Invalid version checks #436
Closed
@popescu-v popescu-v linked an issue Jul 31, 2025 that may be closed by this pull request
Bug in using Khiops with env vars to enable memory stats log analysis #435
Closed
Fix the khiops version initialization independently of the OS
5d05053 
It should always work despite noise (drivers logs, debug info)
@tramora tramora force-pushed the 435-get-khiops-version-among-extra-info branch from f100217 to 5d05053 Compare August 4, 2025 23:26
@tramora tramora merged commit 3f05959 into dev-v10 Aug 4, 2025
19 checks passed
@tramora tramora deleted the 435-get-khiops-version-among-extra-info branch August 4, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@popescu-v popescu-v popescu-v approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in using Khiops with env vars to enable memory stats log analysis

2 participants

@tramora @popescu-v